[asterisk-dev] [Code Review] Replace Berkeley DB astdb with SQLite3

[Terry Wilson]

> On 2011-06-14 00:23:50, Tzafrir Cohen wrote:
> > /trunk/configure.ac, line 1978
> > <https://reviewboard.asterisk.org/r/1269/diff/1/?file=16880#file16880line1978>
> >
> >     AC_MSG_NOTICE prints nothing if configure is run with the --quiet or --silent option.
> >     
> >     Use AC_MSG_WARN instead. Alternatively use a single AC_MSG_ERROR / AC_MSG_FAILURE .

I've made the change to AC_MSG_WARN in my branch. Of course, every other similar situation in our configure.ac uses AC_MSG_NOTICE, so I suppose we will want to change those at some point in the future.


> On 2011-06-14 00:23:50, Tzafrir Cohen wrote:
> > /trunk/main/Makefile, line 37
> > <https://reviewboard.asterisk.org/r/1269/diff/1/?file=16881#file16881line37>
> >
> >     Any need for AST_CFLAGS anywhere? (if a copy of sqlite in a non-standard location is used to build Asterisk)?

I'm pretty sure that if --with-sqlite3 is passed, all of that gets taken care of for us.


- Terry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1269/#review3714
-----------------------------------------------------------


On 2011-06-13 22:56:50, Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1269/
> -----------------------------------------------------------
> 
> (Updated 2011-06-13 22:56:50)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> There have been a couple of bugs reported lately against the Berkeley DB version that Asterisk uses for its internal database. These bugs have been tracked to the actual Berkeley code Asterisk uses, which is very very old and unmaintained. This patch replaces the Berkeley code with SQLite3 while maintaining exactly the same API. If there is no sqlite3 version of the database already and there is a Berkeley DB version, it automatically converts the old database to the new format.
> 
> If this goes in, I would then like to update Olle's patch for Realtime support for astdb as well and get that in.
> 
> 
> Diffs
> -----
> 
>   /configure UNKNOWN 
>   /trunk/configure.ac 323323 
>   /trunk/main/Makefile 323323 
>   /trunk/main/db.c 323323 
>   /trunk/tests/test_db.c 323323 
> 
> Diff: https://reviewboard.asterisk.org/r/1269/diff
> 
> 
> Testing
> -------
> 
> All astdb tests pass and I have tested converting several astdb databases.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110614/788e40bf/attachment.htm>