[asterisk-dev] [Code Review] MOH for only user not working with ConfBridge

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1263/#review3702
-----------------------------------------------------------



trunk/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/1263/#comment7446>

    This works at fixing the most basic symptoms of this issue, but I think there are some edge cases this doesn't address.  It will also result in the join sound only being played for unmarked users. This logic would have to go in both the post_join_unmarked and post_join_marked function to do both.
    
    The big problem here is if we start music on hold and play a prompt back, music on hold stops.  To account for this, there are a few places that attempt to detect if music on hold should be playing by looking at how many users are in the conference and restart it after playing the prompt (DTMF handling code does this).  I don't really like that approach either.
    
    What I would suggest to do is this.  Create a variable/flag on the conference_bridge_user called playing_moh.  When moh is started on a user, set that variable.  When a prompt is played, check that variable. if it is set, stop moh, play the prompt, and start it back up again.   For prompt playback this logic can be isolated to the play_sound_file() function.


- David


On 2011-06-10 09:23:49, opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1263/
> -----------------------------------------------------------
> 
> (Updated 2011-06-10 09:23:49)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> From ASTERISK-17988, MOH was stopped by the join sound being played to the user.  This patch addresses that by moving the join sound playback to a more appropriate location.
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_confbridge.c 322864 
> 
> Diff: https://reviewboard.asterisk.org/r/1263/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110610/a7c92f10/attachment-0001.htm>