[asterisk-dev] [Code Review] Read on idle timerfd will result in deadlocks

[astmiv]

> On 2011-06-04 01:41:08, astmiv wrote:
> > This patch is the combination of two different patches, two issues, for the same problem. The first part before the do loop is from me. The seconds part within the do loop is from someone else. I think the part before the do loop and in the do loop should be merged because the do the same only in a different way.
> > I can create a new patch but should this then be uploaded as a new review. Because I do not see a way of changing this by me. Or the original poster of this post can do it.
> 
> kobaz wrote:
>     Please email me the patch and I'll work on it.  markm at intellasoft.net
> 
> Russell Bryant wrote:
>     Please don't send patches around via email that are going to eventually end up in Asterisk.  They must go through the issue tracker to ensure that they are covered by a contributor license agreement.  Sorry to be difficult.  :-)

Russel,

Should I add the new patch to one of the existing issues or create a new item on the reviewboard?

Regards, Michel.


- astmiv


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1255/#review3677
-----------------------------------------------------------


On 2011-06-03 16:11:22, kobaz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1255/
> -----------------------------------------------------------
> 
> (Updated 2011-06-03 16:11:22)
> 
> 
> Review request for Asterisk Developers and russelb.
> 
> 
> Summary
> -------
> 
> Fix for issue https://issues.asterisk.org/view.php?id=18028
> And several others.
> 
> 
> Diffs
> -----
> 
>   branches/1.8/res/res_timing_timerfd.c 320171 
> 
> Diff: https://reviewboard.asterisk.org/r/1255/diff
> 
> 
> Testing
> -------
> 
> Make enough calls to trigger a read on an idle timer
> 
> Wait for message:
> Reading attempt on idle timerfd. This would have caused a deadlock.
> 
> Deadlock avoided.
> 
> 
> Thanks,
> 
> kobaz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110607/1efb8952/attachment.htm>