[asterisk-dev] [Code Review] Read on idle timerfd will result in deadlocks

[Russell Bryant]

> On 2011-06-03 16:15:29, Russell Bryant wrote:
> > The code looks good.  I'm wondering if we should change all of the WARNING/ERROR messages to ast_debug(1,...) or wrap them in #ifdef AST_DEV_MODE.  I don't want to freak people out, but on development systems, I still want to know when it happens.
> > 
> > Also, it would be great if someone (Leif, maybe?  :-) ) could go through the issue tracker and find all of the open issues that are related to this so that they could be listed in the commit message.

I guess it's not worth delaying getting this change in for the sake of a prettier commit message.  However, I'm still thinking we should change the logging somehow.  My vote is ast_debug(1, ...)


- Russell


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1255/#review3674
-----------------------------------------------------------


On 2011-06-03 16:11:22, kobaz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1255/
> -----------------------------------------------------------
> 
> (Updated 2011-06-03 16:11:22)
> 
> 
> Review request for Asterisk Developers and russelb.
> 
> 
> Summary
> -------
> 
> Fix for issue https://issues.asterisk.org/view.php?id=18028
> And several others.
> 
> 
> Diffs
> -----
> 
>   branches/1.8/res/res_timing_timerfd.c 320171 
> 
> Diff: https://reviewboard.asterisk.org/r/1255/diff
> 
> 
> Testing
> -------
> 
> Make enough calls to trigger a read on an idle timer
> 
> Wait for message:
> Reading attempt on idle timerfd. This would have caused a deadlock.
> 
> Deadlock avoided.
> 
> 
> Thanks,
> 
> kobaz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110603/64cb16c0/attachment.htm>