[asterisk-dev] [Code Review] Stop trying to uri_encode the display name for the caller ID

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1235/#review3668
-----------------------------------------------------------


I'm sorry to have to be a pain in the ass.

RFC3261 25.1, page 221:

   [...] In quoted strings, quotation marks (") and
   backslashes (\) need to be escaped.

      quoted-string  =  SWS DQUOTE *(qdtext / quoted-pair ) DQUOTE
      qdtext         =  LWS / %x21 / %x23-5B / %x5D-7E
                        / UTF8-NONASCII

Your version does not escape backslashes. (Yes, I only mentioned double-quotes in my previous post, sorry about that.)

I would suggest a more generic ast_backslace_escape function, taking an *input, *output, and *chars_to_escape, where chars_to_escape = "\"\\".


Otherwise the patch looks good.

- wdoekes


On 2011-05-31 11:22:36, jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1235/
> -----------------------------------------------------------
> 
> (Updated 2011-05-31 11:22:36)
> 
> 
> Review request for Asterisk Developers, Russell Bryant and David Vossel.
> 
> 
> Summary
> -------
> 
> Under SIP pedantic mode, this function was encoding strings meant for the display name into into a URI safe format when this was not specified in the SIP RFCs.  I also took the liberty of adding a little commentary.
> 
> pedantic mode was the default in Asterisk 1.8+
> 
> 
> This addresses bug 18298.
>     https://issues.asterisk.org/view.php?id=18298
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 321510 
> 
> Diff: https://reviewboard.asterisk.org/r/1235/diff
> 
> 
> Testing
> -------
> 
> A number of different calls with user names including more interesting UTF-8 characters from a variety of characters from a variety of sources including trema (like German umlaut characters), Kanji (Japanese pictographic characters), Sanskrit (phonetic characters for one of India's languages), and Cyrillic (Russian).  Whether or not they'll display properly depends on the receiving phone... My Grandstream phone doesn't like the higher end UTF-8 characters, but all of my soft phones read them fine.
> 
> Testing involved a manually set DAHDI channel to have odd caller ID and an incoming call from another Asterisk Box sending SIP from a phone set to also have a display name with high UTF-8 chars.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110603/f138fd48/attachment.htm>