[asterisk-dev] [Code Review] 0019287: inverse / incorrect behavior for CLI / console logging of DTMF

[jrose]

> On 2011-06-02 13:03:37, David Vossel wrote:
> > wow

Can't do that yet.  Reporter is saying this patch means the defaults get reversed.  Since most of the defaults were zero, they didn't have to be explicitly set when created, so flipping them was fairly easy, but the problem is I have no idea when the DTMF log go toggled and finding where it happened is proving very difficult.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1244/#review3666
-----------------------------------------------------------


On 2011-06-01 15:58:14, jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1244/
> -----------------------------------------------------------
> 
> (Updated 2011-06-01 15:58:14)
> 
> 
> Review request for Asterisk Developers, Russell Bryant and David Vossel.
> 
> 
> Summary
> -------
> 
> ast_network_puts_mutable writes to a connected console client only if it's level was set to false.  This changes that function to write it only if it is set to true to resolve the reverse behavior from expectations issue.
> 
> This seems like the way to go, but I can't see for the life of me why this mistake would be made if it really was just a mistake.  It's hard to say.
> 
> 
> This addresses bug 19287.
>     https://issues.asterisk.org/view.php?id=19287
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/main/asterisk.c 321530 
> 
> Diff: https://reviewboard.asterisk.org/r/1244/diff
> 
> 
> Testing
> -------
> 
> Just tested with a couple of connected clients.  I'll test more tomorrow.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110602/430eb97e/attachment.htm>