[asterisk-dev] [Code Review]: Allow spaces in standard paths and DESTDIR

[Tilghman Lesher]

> On Aug. 8, 2011, 3:09 p.m., Terry Wilson wrote:
> > After updating a little to apply cleanly to trunk, this patch worked for me on both OS X 10.7 and Ubuntu 10.10.

Because the initial support was reverted in 1.8 (because of the lack of DESTDIR support), and because Mac OS X on 1.8 is currently broken, this patch was designed against 1.8.  Just wanted to make that clear.


- Tilghman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1326/#review3999
-----------------------------------------------------------


On July 21, 2011, 11:26 a.m., Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1326/
> -----------------------------------------------------------
> 
> (Updated July 21, 2011, 11:26 a.m.)
> 
> 
> Review request for Asterisk Developers, Russell Bryant and Kevin Fleming.
> 
> 
> Summary
> -------
> 
> Support for spaces in standard paths was recently reverted, because spaces in DESTDIR were not supported.  This patch implements changes allowing spaces within both standard application paths (standard on Mac OS X), as well as within DESTDIR.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/Makefile 328881 
>   /branches/1.8/Makefile.moddir_rules 328881 
>   /branches/1.8/agi/Makefile 328881 
>   /branches/1.8/configure UNKNOWN 
>   /branches/1.8/configure.ac 328881 
>   /branches/1.8/include/asterisk/autoconfig.h.in 328881 
>   /branches/1.8/makeopts.in 328881 
>   /branches/1.8/sounds/Makefile 328881 
>   /branches/1.8/utils/Makefile 328881 
> 
> Diff: https://reviewboard.asterisk.org/r/1326/diff
> 
> 
> Testing
> -------
> 
> Verified that the install routines run correctly when there are spaces in both standard application paths, as well as in DESTDIR.
> 
> 
> Thanks,
> 
> Tilghman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110810/c1d99c11/attachment-0001.htm>