[asterisk-dev] [Code Review] In-queue MOH stops after a periodic announcement

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1328/#review4000
-----------------------------------------------------------

Ship it!


If it blows stuff up, well... that's just more information to look at the problem with.  But I think this has it solved in a rather fail-safe way.

- jrose


On July 21, 2011, 2:56 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1328/
> -----------------------------------------------------------
> 
> (Updated July 21, 2011, 2:56 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> With a g722 call connected to the queue, after listening up to the end of the second song, the music on hold will be interrupted by a generic Allison message about representatives being busy and once the message concludes, the following error will show up:
> 
> WARNING[16606]: format_pcm.c:140 pcm_seek: offset too large 2303040, truncating to 2232088
> 
> and at this point, the music will not resume and interruptions will continue as normal. That message will continue to play with those same values after each interruption.
> 
> Note: This was only experienced with G.722 out of several codecs tested, but could conceivably happen with other codecs.
> 
> 
> This addresses bug ASTERISK-18077.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18077
> 
> 
> Diffs
> -----
> 
>   trunk/res/res_musiconhold.c 329103 
> 
> Diff: https://reviewboard.asterisk.org/r/1328/diff
> 
> 
> Testing
> -------
> 
> Confirmed that the patch fixes the issue described.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110808/4ef6d0f6/attachment.htm>