[asterisk-dev] [Code Review] chan_sip directed pickup deadlock

[Brett Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1175/
-----------------------------------------------------------

(Updated 2011-04-13 12:35:33.287133)


Review request for Asterisk Developers.


Changes
-------

It looks like I overlooked a few things when I submitted this patch earlier.

irroot, I'm starting to review 1166 that you have up now.


Summary
-------

This patch fixes a deadlock which would cause ast_do_masquerade to request a channel lock while already holding a sip_pvt structure, violating locking order and causing deadlocks each time a directed pickup was finished locking up asterisk entirely holding the channels lock.


Diffs (updated)
-----

  /team/bbryant/sip-call-pickup/channels/chan_sip.c 313524 

Diff: https://reviewboard.asterisk.org/r/1175/diff


Testing
-------


Thanks,

Brett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110413/f2ef4290/attachment.htm>