[asterisk-dev] [Code Review] chan_sip directed pickup deadlock

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1175/#review3328
-----------------------------------------------------------


Yes indeed please see the patch ive just put up for RB 1166 it deals with the avoidance of this as well as some related locks.

you are cleaning one of the deadlock paths one i have not encountered yet ;)

you do have a double unlock if ast_pickup_call follows the else ??



- irroot


On 2011-04-13 09:36:11, Brett Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1175/
> -----------------------------------------------------------
> 
> (Updated 2011-04-13 09:36:11)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch fixes a deadlock which would cause ast_do_masquerade to request a channel lock while already holding a sip_pvt structure, violating locking order and causing deadlocks each time a directed pickup was finished locking up asterisk entirely holding the channels lock.
> 
> 
> Diffs
> -----
> 
>   /team/bbryant/sip-call-pickup/channels/chan_sip.c 313525 
> 
> Diff: https://reviewboard.asterisk.org/r/1175/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110413/a98db0b3/attachment.htm>