[asterisk-dev] [Code Review] Use full path for Asterisk binary

reviewboard at asterisk.org reviewboard at asterisk.org
Wed Nov 17 14:39:15 CST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1015/
-----------------------------------------------------------

(Updated 2010-11-17 14:39:15.605726)


Review request for Asterisk Developers.


Changes
-------

Final version before commit


Summary
-------

Add full path support for Asterisk binary, this fixes builds on CentOS.  However hardcodes /usr/sbin/asterisk as the path, but we already do it for most Asterisk settings. A future patch should parse the makeopts file to read the OS specific settings.

Also add some try / catch logic when starting Asterisk.


Diffs (updated)
-----

  asterisk/trunk/lib/python/asterisk/__init__.py 847 
  asterisk/trunk/lib/python/asterisk/asterisk.py 847 
  asterisk/trunk/lib/python/asterisk/utils.py PRE-CREATION 
  asterisk/trunk/runtests.py 847 

Diff: https://reviewboard.asterisk.org/r/1015/diff


Testing
-------


Thanks,

Paul

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101117/c9d306ab/attachment-0001.htm 


More information about the asterisk-dev mailing list