[asterisk-dev] [Code Review] Use full path for Asterisk binary

[reviewboard at asterisk.org]

> On 2010-11-17 13:35:40, Russell Bryant wrote:
> > asterisk/trunk/lib/python/asterisk/asterisk.py, lines 64-68
> > <https://reviewboard.asterisk.org/r/1015/diff/3/?file=12933#file12933line64>
> >
> >     I think this can be cut down to ....
> >     
> >     self.ast_binary = utils.which("asterisk") or "/usr/sbin/asterisk"

done.


> On 2010-11-17 13:35:40, Russell Bryant wrote:
> > asterisk/trunk/lib/python/utils.py, lines 3-5
> > <https://reviewboard.asterisk.org/r/1015/diff/3/?file=12934#file12934line3>
> >
> >     fix this comment

This module provides access to Asterisk testsuite utility functions from within python code.

Thoughts?


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1015/#review2926
-----------------------------------------------------------


On 2010-11-17 13:36:07, Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1015/
> -----------------------------------------------------------
> 
> (Updated 2010-11-17 13:36:07)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Add full path support for Asterisk binary, this fixes builds on CentOS.  However hardcodes /usr/sbin/asterisk as the path, but we already do it for most Asterisk settings. A future patch should parse the makeopts file to read the OS specific settings.
> 
> Also add some try / catch logic when starting Asterisk.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/runtests.py 847 
>   asterisk/trunk/lib/python/asterisk/asterisk.py 847 
>   asterisk/trunk/lib/python/utils.py PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/1015/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101117/70f2eb0d/attachment.htm