[asterisk-dev] [Code Review] Add abliity for logger channels to include *all* levels

Nick Lewis Nick.Lewis at atltelecom.com
Thu May 20 05:56:46 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/663/#review2035
-----------------------------------------------------------



/trunk/main/logger.c
<https://reviewboard.asterisk.org/r/663/#comment4318>

    Why is this 0xFFFF rather than 0XFFFFFFFF
    I may have misunderstood but are not the dynamic levels that you wish to allow the ones between 16-31. If so it would appear that 0xFFFF would only allow the static levels 


- Nick


On 2010-05-18 11:58:24, Kevin Fleming wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/663/
> -----------------------------------------------------------
> 
> (Updated 2010-05-18 11:58:24)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Now that Asterisk modules can dynamically create and destroy logger levels on demand, it's useful to be able to configure a logger channel (console, file, whatever) to be able to accept log messages from *all* levels, even levels created dynamically. This patch adds support for this, by allowing the '*' level name to be used in logger.conf.
> 
> 
> Diffs
> -----
> 
>   /trunk/configs/logger.conf.sample 263767 
>   /trunk/main/logger.c 263767 
> 
> Diff: https://reviewboard.asterisk.org/r/663/diff
> 
> 
> Testing
> -------
> 
> Compile testing only.
> 
> 
> Thanks,
> 
> Kevin
> 
>




More information about the asterisk-dev mailing list