[asterisk-dev] [Code Review] Add abliity for logger channels to include *all* levels

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/663/#review2021
-----------------------------------------------------------

Ship it!


One thing I noticed while looking at your review is that the "found" variable in make_components() is not actually used for anything useful and can be removed.

Good work!


/trunk/configs/logger.conf.sample
<https://reviewboard.asterisk.org/r/663/#comment4304>

    Maybe I'm being a bit paranoid, but the parenthetical comment stating that no reload is required may be misconstrued. For instance, it seems reasonable for someone reading this to think that they can add the '*' level to a log channel in logger.conf and not need to reload after making the change.


- Mark


On 2010-05-18 11:58:24, Kevin Fleming wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/663/
> -----------------------------------------------------------
> 
> (Updated 2010-05-18 11:58:24)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Now that Asterisk modules can dynamically create and destroy logger levels on demand, it's useful to be able to configure a logger channel (console, file, whatever) to be able to accept log messages from *all* levels, even levels created dynamically. This patch adds support for this, by allowing the '*' level name to be used in logger.conf.
> 
> 
> Diffs
> -----
> 
>   /trunk/configs/logger.conf.sample 263767 
>   /trunk/main/logger.c 263767 
> 
> Diff: https://reviewboard.asterisk.org/r/663/diff
> 
> 
> Testing
> -------
> 
> Compile testing only.
> 
> 
> Thanks,
> 
> Kevin
> 
>