[asterisk-dev] [Code Review] New dialplan application VMSayname with unit test

[Jeff Peeler]

> On 2010-03-01 17:56:22, David Vossel wrote:
> > /trunk/apps/app_voicemail.c, line 11907
> > <https://reviewboard.asterisk.org/r/530/diff/2/?file=8411#file8411line11907>
> >
> >     What does this do when TEST_FRAMEWORK is not enabled?  the AST_TEST_UNREGISTER macro is just a no-op then.

Actually it won't even compile, so until the test framework is modified (if that is wanted) I'll ifdef it out.


- Jeff


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/530/#review1618
-----------------------------------------------------------


On 2010-02-26 13:44:09, Jeff Peeler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/530/
> -----------------------------------------------------------
> 
> (Updated 2010-02-26 13:44:09)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds a new application, VMSayName, which plays the greeting for a given voicemail user specified by extension and optionally context. If the greeting does not exist, currently the extension is played back.
> 
> 
> This addresses bug 14973.
>     https://issues.asterisk.org/view.php?id=14973
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_voicemail.c 249231 
> 
> Diff: https://reviewboard.asterisk.org/r/530/diff
> 
> 
> Testing
> -------
> 
> A unit test has been created to test the code paths used for playback in the case when the greeting is present and when it is not. Because the application is really just a wrapper function, the unit test is what needs to be examined more so than anything else.
> 
> 
> Thanks,
> 
> Jeff
> 
>