[asterisk-dev] [Code Review] New dialplan application VMSayname with unit test

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/530/#review1618
-----------------------------------------------------------

Ship it!


This looks good Jeff!  had a couple of comments.  Take a look and then I believe this is ready to go!


/trunk/apps/app_voicemail.c
<https://reviewboard.asterisk.org/r/530/#comment3624>

    What does this do when TEST_FRAMEWORK is not enabled?  the AST_TEST_UNREGISTER macro is just a no-op then.



/trunk/apps/app_voicemail.c
<https://reviewboard.asterisk.org/r/530/#comment3623>

    same thing I said about AST_TEST_UNREGISTER applies here.  I just don't know how the compiler treats this.


- David


On 2010-02-26 13:44:09, Jeff Peeler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/530/
> -----------------------------------------------------------
> 
> (Updated 2010-02-26 13:44:09)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds a new application, VMSayName, which plays the greeting for a given voicemail user specified by extension and optionally context. If the greeting does not exist, currently the extension is played back.
> 
> 
> This addresses bug 14973.
>     https://issues.asterisk.org/view.php?id=14973
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_voicemail.c 249231 
> 
> Diff: https://reviewboard.asterisk.org/r/530/diff
> 
> 
> Testing
> -------
> 
> A unit test has been created to test the code paths used for playback in the case when the greeting is present and when it is not. Because the application is really just a wrapper function, the unit test is what needs to be examined more so than anything else.
> 
> 
> Thanks,
> 
> Jeff
> 
>