[Asterisk-code-review] app_signal: Add signaling applications (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, Mark Murawski.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17786 )

Change subject: app_signal: Add signaling applications
......................................................................


Patch Set 7:

(4 comments)

File apps/app_signal.c:

https://gerrit.asterisk.org/c/asterisk/+/17786/comment/267aefd3_c1af5893 
PS6, Line 55: 			<para>Sends a named signal to any channels that may be
> You can add example usage of Signal/WaitForSignal […]
Done


https://gerrit.asterisk.org/c/asterisk/+/17786/comment/60158c05_be062495 
PS6, Line 373: 		ast_verb(3, "Channel '%s' timed out, waiting for signal '%s'\n", ast_channel_name(chan), args.signame);
> For completeness, I think it would be prudent to send AMI events for all the different things that m […]
I'm not sure what there could be on the "waiting for" part...
What would the AMI event accomplish exactly? Since this is being done from dialplan, if we wanted an event, we could just do same => n,UserEvent(foobar) for instance to trigger that. I'm not sure how I feel about building it in since this is really for dialplan-to-dialplan, not really relevant to AMI.


https://gerrit.asterisk.org/c/asterisk/+/17786/comment/2bab169e_ca198cee 
PS6, Line 379: 		pbx_builtin_setvar_helper(chan, "WAITFORSIGNALSTATUS", "HANGUP");
> ast_verb(3, "Channel hung up"); […]
Done


https://gerrit.asterisk.org/c/asterisk/+/17786/comment/b94d97ec_d414bf19 
PS6, Line 453: oad
> For completeness, I would like to see cli and ami commands to show channels currently waiting for si […]
Isn't this kind of redundant?
core show channels already shows what applications channels are executing. If it's executing "WaitForSignal", then we know it's waiting for a signal, and what signal. I'm not sure what this would really add.

DumpSignals() likewise seems pointless to me. If a channel is executing DumpSignals(), it's not waiting for any signals. It can only be waiting on a signal if it's executing WaitForSignal().



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17786
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic34439de3d60f8609357666a465c354d81f5fef3
Gerrit-Change-Number: 17786
Gerrit-PatchSet: 7
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Mark Murawski <markm at intellasoft.net>
Gerrit-Comment-Date: Thu, 26 Jan 2023 14:00:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mark Murawski <markm at intellasoft.net>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230126/985e4a22/attachment.html>