<p> Attention is currently required from: Joshua Colp, Mark Murawski. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/17786">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File apps/app_signal.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17786/comment/267aefd3_c1af5893">Patch Set #6, Line 55:</a> <code style="font-family:monospace,monospace"> <para>Sends a named signal to any channels that may be</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">You can add example usage of Signal/WaitForSignal […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17786/comment/60158c05_be062495">Patch Set #6, Line 373:</a> <code style="font-family:monospace,monospace"> ast_verb(3, "Channel '%s' timed out, waiting for signal '%s'\n", ast_channel_name(chan), args.signame);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">For completeness, I think it would be prudent to send AMI events for all the different things that m […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'm not sure what there could be on the "waiting for" part...<br>What would the AMI event accomplish exactly? Since this is being done from dialplan, if we wanted an event, we could just do same => n,UserEvent(foobar) for instance to trigger that. I'm not sure how I feel about building it in since this is really for dialplan-to-dialplan, not really relevant to AMI.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17786/comment/2bab169e_ca198cee">Patch Set #6, Line 379:</a> <code style="font-family:monospace,monospace"> pbx_builtin_setvar_helper(chan, "WAITFORSIGNALSTATUS", "HANGUP");</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">ast_verb(3, "Channel hung up"); […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17786/comment/b94d97ec_d414bf19">Patch Set #6, Line 453:</a> <code style="font-family:monospace,monospace">oad</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">For completeness, I would like to see cli and ami commands to show channels currently waiting for si […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Isn't this kind of redundant?<br>core show channels already shows what applications channels are executing. If it's executing "WaitForSignal", then we know it's waiting for a signal, and what signal. I'm not sure what this would really add.</p><p style="white-space: pre-wrap; word-wrap: break-word;">DumpSignals() likewise seems pointless to me. If a channel is executing DumpSignals(), it's not waiting for any signals. It can only be waiting on a signal if it's executing WaitForSignal().</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/17786">change 17786</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/17786"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic34439de3d60f8609357666a465c354d81f5fef3 </div>
<div style="display:none"> Gerrit-Change-Number: 17786 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Mark Murawski <markm@intellasoft.net> </div>
<div style="display:none"> Gerrit-Reviewer: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Mark Murawski <markm@intellasoft.net> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 26 Jan 2023 14:00:26 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Mark Murawski <markm@intellasoft.net> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>