[Asterisk-code-review] app_signal: Add signaling applications (asterisk[master])

[Mark Murawski]

Attention is currently required from: N A, Joshua Colp.

Mark Murawski has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17786 )

Change subject: app_signal: Add signaling applications
......................................................................


Patch Set 6:

(4 comments)

File apps/app_signal.c:

https://gerrit.asterisk.org/c/asterisk/+/17786/comment/97394179_f9dc011b 
PS6, Line 55: 			<para>Sends a named signal to any channels that may be
You can add example usage of Signal/WaitForSignal

Also, I would use a more user-friendly name for the param than signame... something like signal_name.


https://gerrit.asterisk.org/c/asterisk/+/17786/comment/35e8ded2_ad301201 
PS6, Line 373: 		ast_verb(3, "Channel '%s' timed out, waiting for signal '%s'\n", ast_channel_name(chan), args.signame);
For completeness, I think it would be prudent to send AMI events for all the different things that might happen with sending a Signal and waiting for a Signal


https://gerrit.asterisk.org/c/asterisk/+/17786/comment/70c79a57_31d80e5f 
PS6, Line 379: 		pbx_builtin_setvar_helper(chan, "WAITFORSIGNALSTATUS", "HANGUP");
ast_verb(3, "Channel hung up");

Like in app_read.c that says "User disconnected" on hangup.  Although my preference is to say hung up vs disconnected.


https://gerrit.asterisk.org/c/asterisk/+/17786/comment/b923bb0d_654179ea 
PS6, Line 453: oad
For completeness, I would like to see cli and ami commands to show channels currently waiting for signals.

Also you can add an app DumpSignals (like DumpChans/DumpGroups/etc).  This sort of stuff is always incredibly useful for debugging running systems or working on implementation of complex systems



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17786
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic34439de3d60f8609357666a465c354d81f5fef3
Gerrit-Change-Number: 17786
Gerrit-PatchSet: 6
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Sat, 14 Jan 2023 21:38:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230114/cf9d69da/attachment-0001.html>