<p> Attention is currently required from: N A, Joshua Colp. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/17786">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File apps/app_signal.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17786/comment/97394179_f9dc011b">Patch Set #6, Line 55:</a> <code style="font-family:monospace,monospace">                  <para>Sends a named signal to any channels that may be</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">You can add example usage of Signal/WaitForSignal</p><p style="white-space: pre-wrap; word-wrap: break-word;">Also, I would use a more user-friendly name for the param than signame... something like signal_name.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17786/comment/35e8ded2_ad301201">Patch Set #6, Line 373:</a> <code style="font-family:monospace,monospace">                ast_verb(3, "Channel '%s' timed out, waiting for signal '%s'\n", ast_channel_name(chan), args.signame);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">For completeness, I think it would be prudent to send AMI events for all the different things that might happen with sending a Signal and waiting for a Signal</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17786/comment/70c79a57_31d80e5f">Patch Set #6, Line 379:</a> <code style="font-family:monospace,monospace">              pbx_builtin_setvar_helper(chan, "WAITFORSIGNALSTATUS", "HANGUP");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">ast_verb(3, "Channel hung up");</p><p style="white-space: pre-wrap; word-wrap: break-word;">Like in app_read.c that says "User disconnected" on hangup.  Although my preference is to say hung up vs disconnected.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17786/comment/b923bb0d_654179ea">Patch Set #6, Line 453:</a> <code style="font-family:monospace,monospace">oad</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">For completeness, I would like to see cli and ami commands to show channels currently waiting for signals.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Also you can add an app DumpSignals (like DumpChans/DumpGroups/etc).  This sort of stuff is always incredibly useful for debugging running systems or working on implementation of complex systems</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/17786">change 17786</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/17786"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic34439de3d60f8609357666a465c354d81f5fef3 </div>
<div style="display:none"> Gerrit-Change-Number: 17786 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Mark Murawski <markm@intellasoft.net> </div>
<div style="display:none"> Gerrit-Reviewer: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Attention: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 14 Jan 2023 21:38:09 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>