[Asterisk-code-review] func_groupcount.c: Adding Group Variables + additional Group functions (asterisk[18])

[N A]

Attention is currently required from: Mark Murawski.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17655 )

Change subject: func_groupcount.c: Adding Group Variables + additional Group functions
......................................................................


Patch Set 20: Code-Review-1

(6 comments)

File funcs/func_groupcount.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/7dae1236_e1087100 
PS20, Line 709: 	return -1;
Is it appropriate to return -1 here? I think this will shut down the entire AMI connection


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/c4b5c07b_fb75b671 
PS20, Line 723: 	return -1;
Same here, I think this needs to return 0


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/9e894baa_b9e8db41 
PS20, Line 1181: 	buf[0] = '0'; buf[1] = 0;
Either use a comma, or put these on separate lines.


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/b78d15b1_15ec4db5 
PS20, Line 1227: 		return 0;
This is a function, so it is safe (and better) to return -1 on failure
Any failures in this function should return -1


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/a91726f7_cdad0cc0 
PS20, Line 1328: 		return 0;
Should this return -1?


File main/app.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/a5cd6c47_a22452f3 
PS20, Line 2488: {
The * should go with the function name



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17655
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I23e48d1cdfc8adaffdfec2e936e56143603914f2
Gerrit-Change-Number: 17655
Gerrit-PatchSet: 20
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Mark Murawski <markm at intellasoft.net>
Gerrit-Comment-Date: Sat, 14 Jan 2023 14:01:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230114/1a69ca3d/attachment.html>