[Asterisk-code-review] func_groupcount.c: Adding Group Variables + additional Group functions (asterisk[18])

[Mark Murawski]

Attention is currently required from: N A.

Mark Murawski has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17655 )

Change subject: func_groupcount.c: Adding Group Variables + additional Group functions
......................................................................


Patch Set 20:

(9 comments)

Patchset:

PS8: 
> I'm entirely agreeing that a container would solve this issue. […]
Done


File funcs/func_groupcount.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/bb5c39e4_9e4dee87 
PS19, Line 79: 			<para>Uses standard regular expression matching (see regex(7)).</para>
> Just caught another issue with your xmldocs: […]
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/e867dc64_ac816e9c 
PS19, Line 1041: 
> I think ast_str_create can fail... you should check for failure everywhere you call this.
Done


File main/app.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/4018dda9_83c6ce45 
PS19, Line 2423: int ast_app_group_set_var(struct ast_channel *chan, const char *group, const char *category, const char *name, const char *value) {
> Opening brace should be on a separate line (K&R)
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/c32b4ae4_05243013 
PS19, Line 2487: const char* ast_app_group_get_var(const char *group, const char *category, const char *name) {
> Opening brace should be on a separate line (K&R)
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/80ff9e1b_f4b26321 
PS19, Line 2668: int ast_app_group_add_channel(struct ast_channel *chan, char *group, char *category) {
> Opening brace should be on a separate line (K&R)
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/5f14ddb9_8d6c8416 
PS19, Line 2716: int ast_app_group_remove_all_channels(const char *group, const char *category) {
> Opening brace should be on a separate line (K&R)
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/e94e88dd_e356a8b2 
PS19, Line 2745: int ast_app_group_rename(const char *old_group, const char *old_category, const char *new_group, const char *new_category) {
> Opening brace should be on a separate line (K&R)
Done


File main/cli.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/93f8765d_916c1f09 
PS19, Line 1909: int group_show_channels_callback(void *obj, void *arg, int flags);
> Why do we need this forward declaration? […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17655
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I23e48d1cdfc8adaffdfec2e936e56143603914f2
Gerrit-Change-Number: 17655
Gerrit-PatchSet: 20
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Sat, 14 Jan 2023 02:08:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: Mark Murawski <markm at intellasoft.net>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230114/dbc48dff/attachment.html>