[Asterisk-code-review] res_pjsip_aoc: New module for sending advice-of-charge with chan_pjsip (asterisk[master])

[Michael Kuron]

Attention is currently required from: Joshua Colp, N A.

Michael Kuron has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19460 )

Change subject: res_pjsip_aoc: New module for sending advice-of-charge with chan_pjsip
......................................................................


Patch Set 10:

(1 comment)

File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/19460/comment/2d8da881_b8a5fbec 
PS9, Line 4280: 		handle_outgoing_response(session, tdata);
> This is currently done by the ast_sip_session_send_response function. […]
It does appear to get called twice for some responses and should thus be removed from ast_sip_session_send_response. I think all the calls to ast_sip_session_send_response will eventually trigger session_on_tx_response, so the removal should have no negative impact, but I am not familiar enough with the code to say for sure -- this definitely needs a second pair of eyes from someone who is more familiar with the inner workings of PJSIP.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19460
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iebb7ad0d5f88526bc6629d3a1f9f11665434d333
Gerrit-Change-Number: 19460
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Kuron <m.kuron at gmx.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Wed, 02 Nov 2022 22:42:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221102/fe2c785b/attachment.html>