[Asterisk-code-review] res_pjsip_aoc: New module for sending advice-of-charge with chan_pjsip (asterisk[master])

[Michael Kuron]

Attention is currently required from: Joshua Colp, N A.

Michael Kuron has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19460 )

Change subject: res_pjsip_aoc: New module for sending advice-of-charge with chan_pjsip
......................................................................


Patch Set 10:

(3 comments)

Patchset:

PS2: 
> Thanks, I figured out how to do the config option. […]
I have put up a patch for the test coverage and will shortly put up another patch for AOC-S AMI support. That only leaves one question: is this change eligible for cherry-picking to the 20 branch?


File configs/samples/pjsip.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/19460/comment/6c49bdc8_07e26be6 
PS8, Line 969:                 ; (default: no)
> That would be best as a separate patch.
Done


File doc/CHANGES-staging/res_pjsip_aoc.txt:

https://gerrit.asterisk.org/c/asterisk/+/19460/comment/90e00f99_d8c83faf 
PS9, Line 3: Added res_pjsip_aoc which gives chan_pjsip the ability to send Advice-of-Charge messages
> Document in here that it is controlled using the "send_aoc" option on the endpoint.
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19460
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iebb7ad0d5f88526bc6629d3a1f9f11665434d333
Gerrit-Change-Number: 19460
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Kuron <m.kuron at gmx.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Wed, 02 Nov 2022 22:33:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: Michael Kuron <m.kuron at gmx.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221102/f3dc8fd4/attachment-0001.html>