[Asterisk-code-review] pjsip: Add tests that verify wildcard cert-bearing servers (testsuite[16])

[Kevin Harwell]

Attention is currently required from: Joshua Colp.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/18573 )

Change subject: pjsip: Add tests that verify wildcard cert-bearing servers
......................................................................


Patch Set 1:

(2 comments)

File lib/python/asterisk/sipp.py:

https://gerrit.asterisk.org/c/testsuite/+/18573/comment/795184c0_8fb2897a 
PS1, Line 650: #            '%s/sipp/%s' % (self.test_dir, self.scenario['scenario']),
> Should this just be removed instead of being commented out?
Done


File tests/channels/pjsip/secure_calling/calls/nominal/allow_wildcard_certs/cn/keys/README.txt:

https://gerrit.asterisk.org/c/testsuite/+/18573/comment/9aed0cf9_31f29422 
PS1, Line 2: 
> what's the expiry on the generated certs?
Apparently there is no such thing as "infinite" expiry if you don't specify days. Anyhoo updated to include "-days 999999" which puts it in April 4760. Long after I have to worry about it :-D



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/18573
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-Change-Id: I2d4cf66b642ccf97a6b275e1425c0cbfad5eb0ab
Gerrit-Change-Number: 18573
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 26 May 2022 21:31:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220526/357ee935/attachment.html>