[Asterisk-code-review] pjsip: Add tests that verify wildcard cert-bearing servers (testsuite[16])
Joshua Colp
asteriskteam at digium.com
Mon May 23 11:10:44 CDT 2022
Attention is currently required from: Kevin Harwell.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/18573 )
Change subject: pjsip: Add tests that verify wildcard cert-bearing servers
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
File lib/python/asterisk/sipp.py:
https://gerrit.asterisk.org/c/testsuite/+/18573/comment/ee67faa2_caaaa8d2
PS1, Line 650: # '%s/sipp/%s' % (self.test_dir, self.scenario['scenario']),
Should this just be removed instead of being commented out?
File tests/channels/pjsip/secure_calling/calls/nominal/allow_wildcard_certs/cn/keys/README.txt:
https://gerrit.asterisk.org/c/testsuite/+/18573/comment/f80850a1_906d1395
PS1, Line 2:
what's the expiry on the generated certs?
--
To view, visit https://gerrit.asterisk.org/c/testsuite/+/18573
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-Change-Id: I2d4cf66b642ccf97a6b275e1425c0cbfad5eb0ab
Gerrit-Change-Number: 18573
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 23 May 2022 16:10:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220523/21666ca1/attachment.html>
More information about the asterisk-code-review
mailing list