[Asterisk-code-review] res_agi: Evaluate dialplan functions and variables in agi exec if ena... (asterisk[16])

[Joshua Colp]

Attention is currently required from: Shloime Rosenblum.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18540 )

Change subject: res_agi: Evaluate dialplan functions and variables in agi exec if enabled
......................................................................


Patch Set 4: Code-Review-1

(4 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18540/comment/a177df74_8e753cd9 
PS4, Line 11: be useful when executing Playback or Read from agi.
redness


File doc/CHANGES-staging/res_agi.txt:

https://gerrit.asterisk.org/c/asterisk/+/18540/comment/730d7544_3676b639 
PS4, Line 3: Agi command 'exec' can now be enabled 
redness


https://gerrit.asterisk.org/c/asterisk/+/18540/comment/1c285882_fe83128b 
PS4, Line 4: to evaluate dialplan functions and variables 
redness


File res/res_agi.c:

https://gerrit.asterisk.org/c/asterisk/+/18540/comment/d06992b7_961f86c7 
PS4, Line 3141: 		agi_exec_full_str = pbx_builtin_getvar_helper(chan, "AGIEXECFULL");
This should be done with the channel lock held. The easiest way would be to do this during the workaround check, including the ast_true, and then set an int to 1 if it should be done when the channel lock is released.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18540
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I669991f540496e7bddd096fec82b52c083036832
Gerrit-Change-Number: 18540
Gerrit-PatchSet: 4
Gerrit-Owner: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-Comment-Date: Thu, 26 May 2022 11:56:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220526/be4b6e73/attachment.html>