<p> Attention is currently required from: Shloime Rosenblum. </p>
<p>Patch set 4:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/18540">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18540/comment/a177df74_8e753cd9">Patch Set #4, Line 11:</a> <code style="font-family:monospace,monospace">be useful when executing Playback or Read from agi.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">redness</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File doc/CHANGES-staging/res_agi.txt:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18540/comment/730d7544_3676b639">Patch Set #4, Line 3:</a> <code style="font-family:monospace,monospace">Agi command 'exec' can now be enabled </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">redness</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18540/comment/1c285882_fe83128b">Patch Set #4, Line 4:</a> <code style="font-family:monospace,monospace">to evaluate dialplan functions and variables </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">redness</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_agi.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18540/comment/d06992b7_961f86c7">Patch Set #4, Line 3141:</a> <code style="font-family:monospace,monospace">         agi_exec_full_str = pbx_builtin_getvar_helper(chan, "AGIEXECFULL");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This should be done with the channel lock held. The easiest way would be to do this during the workaround check, including the ast_true, and then set an int to 1 if it should be done when the channel lock is released.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18540">change 18540</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18540"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I669991f540496e7bddd096fec82b52c083036832 </div>
<div style="display:none"> Gerrit-Change-Number: 18540 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Shloime Rosenblum <shloimerosenblum@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Attention: Shloime Rosenblum <shloimerosenblum@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 26 May 2022 11:56:04 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>