[Asterisk-code-review] Add support for Python 3 (starpy[1.1])

[Kevin Harwell]

Attention is currently required from: Michael Bradeen.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/starpy/+/18244 )

Change subject: Add support for Python 3
......................................................................


Patch Set 3: Code-Review-1

(3 comments)

File starpy/fastagi.py:

https://gerrit.asterisk.org/c/starpy/+/18244/comment/874a925b_cebfb6ec 
PS3, Line 120:         linestring = line.decode("utf-8")
since all "line" change to "linestring" just make this line = line.decode("utf-8") then this will be the only line that needs adding/changing.


File starpy/manager.py:

https://gerrit.asterisk.org/c/starpy/+/18244/comment/5d0a745d_fb027258 
PS2, Line 734:         nowait -- make the origination asynchronous
> Might have to fight George for the naming rights. […]
I'm somewhat ambivalent. If someone else feels strongly that's fine too.


File starpy/manager.py:

https://gerrit.asterisk.org/c/starpy/+/18244/comment/b025c9ee_5fce217e 
PS3, Line 171:         linestring = line.decode("utf-8")
Same here just make line = line.decode("utf-8")



-- 
To view, visit https://gerrit.asterisk.org/c/starpy/+/18244
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: starpy
Gerrit-Branch: 1.1
Gerrit-Change-Id: I2fab42abb5318a5db2af3bcd291fc2db95b87e15
Gerrit-Change-Number: 18244
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Thu, 09 Jun 2022 21:36:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Michael Bradeen <mbradeen at sangoma.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220609/45be877b/attachment.html>