<p> Attention is currently required from: Michael Bradeen. </p>
<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/starpy/+/18244">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File starpy/fastagi.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/starpy/+/18244/comment/874a925b_cebfb6ec">Patch Set #3, Line 120:</a> <code style="font-family:monospace,monospace">        linestring = line.decode("utf-8")</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">since all "line" change to "linestring" just make this line = line.decode("utf-8") then this will be the only line that needs adding/changing.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File starpy/manager.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/starpy/+/18244/comment/5d0a745d_fb027258">Patch Set #2, Line 734:</a> <code style="font-family:monospace,monospace">        nowait -- make the origination asynchronous</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Might have to fight George for the naming rights. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'm somewhat ambivalent. If someone else feels strongly that's fine too.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File starpy/manager.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/starpy/+/18244/comment/b025c9ee_5fce217e">Patch Set #3, Line 171:</a> <code style="font-family:monospace,monospace">        linestring = line.decode("utf-8")</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same here just make line = line.decode("utf-8")</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/starpy/+/18244">change 18244</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/starpy/+/18244"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: starpy </div>
<div style="display:none"> Gerrit-Branch: 1.1 </div>
<div style="display:none"> Gerrit-Change-Id: I2fab42abb5318a5db2af3bcd291fc2db95b87e15 </div>
<div style="display:none"> Gerrit-Change-Number: 18244 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Attention: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 09 Jun 2022 21:36:51 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Comment-In-Reply-To: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Comment-In-Reply-To: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>