[Asterisk-code-review] app_mp3: Document and warn about https incompatibility. (asterisk[master])

[Sean Bright]

Attention is currently required from: N A.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18002 )

Change subject: app_mp3: Document and warn about https incompatibility.
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

File apps/app_mp3.c:

https://gerrit.asterisk.org/c/asterisk/+/18002/comment/5b0cd91c_e59ef708 
PS1, Line 67: http://en.wikipedia.org/wiki/M3U
While you're here, change this URL to be https://...


https://gerrit.asterisk.org/c/asterisk/+/18002/comment/b31d3eb3_f55cb009 
PS1, Line 69: 			<para>Note that mpg123 does not support https, so use http for web streams.</para>
Capitalize HTTP and HTTPS


https://gerrit.asterisk.org/c/asterisk/+/18002/comment/4cd451f9_fd4aa90c 
PS1, Line 256: 							ast_log(LOG_WARNING, "mpg123 does not support https streams. Use http instead.\n");
Consumers of the MP3Player app won't necessarily know that it uses mpg123/mpg321 under the hood so use the application name instead (and capitalize the protocols):

 ast_log(LOG_WARNING, "%s() does not support HTTPS streams. Use HTTP instead.\n", app);


https://gerrit.asterisk.org/c/asterisk/+/18002/comment/df4e9459_883c6f3b 
PS1, Line 312: AST_MODULE_INFO_STANDARD_EXTENDED(ASTERISK_GPL_KEY, "MP3 Player Application");
No need to change this bit.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18002
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie3b029be5258c5a701f71ed3b1a7a80d1e03b827
Gerrit-Change-Number: 18002
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Sat, 05 Feb 2022 21:15:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220205/db279fa7/attachment.html>