<p> Attention is currently required from: N A. </p>
<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/18002">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File apps/app_mp3.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18002/comment/5b0cd91c_e59ef708">Patch Set #1, Line 67:</a> <code style="font-family:monospace,monospace">http://en.wikipedia.org/wiki/M3U</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">While you're here, change this URL to be https://...</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18002/comment/b31d3eb3_f55cb009">Patch Set #1, Line 69:</a> <code style="font-family:monospace,monospace">                 <para>Note that mpg123 does not support https, so use http for web streams.</para></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Capitalize HTTP and HTTPS</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18002/comment/4cd451f9_fd4aa90c">Patch Set #1, Line 256:</a> <code style="font-family:monospace,monospace">                                                      ast_log(LOG_WARNING, "mpg123 does not support https streams. Use http instead.\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Consumers of the MP3Player app won't necessarily know that it uses mpg123/mpg321 under the hood so use the application name instead (and capitalize the protocols):</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> ast_log(LOG_WARNING, "%s() does not support HTTPS streams. Use HTTP instead.\n", app);</pre></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18002/comment/df4e9459_883c6f3b">Patch Set #1, Line 312:</a> <code style="font-family:monospace,monospace">AST_MODULE_INFO_STANDARD_EXTENDED(ASTERISK_GPL_KEY, "MP3 Player Application");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">No need to change this bit.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18002">change 18002</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18002"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie3b029be5258c5a701f71ed3b1a7a80d1e03b827 </div>
<div style="display:none"> Gerrit-Change-Number: 18002 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 05 Feb 2022 21:15:18 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>