[Asterisk-code-review] res_geolocation: Add initial markdown for Geolocation wiki pages (asterisk[development/16/geolocation])
Kevin Harwell
asteriskteam at digium.com
Wed Apr 13 17:31:05 CDT 2022
Attention is currently required from: Joshua Colp, George Joseph.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18360 )
Change subject: res_geolocation: Add initial markdown for Geolocation wiki pages
......................................................................
Patch Set 1: Code-Review-1
(8 comments)
File res/res_geolocation/wiki/AsteriskImplementation.md:
https://gerrit.asterisk.org/c/asterisk/+/18360/comment/a95e89d3_3ba33e6b
PS1, Line 80: Any parameter than can use channel variables can also arbitrary variables defined in this paramete
s/than/that?
The end reads oddly too, "..can also arbitrary variables defined.."? I'm not sure what that means.
https://gerrit.asterisk.org/c/asterisk/+/18360/comment/5071ccc6_1852eafb
PS1, Line 80: pof
pof?
https://gerrit.asterisk.org/c/asterisk/+/18360/comment/0f837a6f_9d7d64bd
PS1, Line 101: descibes
s/descibes/describes
https://gerrit.asterisk.org/c/asterisk/+/18360/comment/db0eaa9f_3ae5d274
PS1, Line 133: this..
extra period here?
https://gerrit.asterisk.org/c/asterisk/+/18360/comment/7394f687_aea61789
PS1, Line 144: would exactly
would be exactly
File res/res_geolocation/wiki/CivicAddress.md:
https://gerrit.asterisk.org/c/asterisk/+/18360/comment/2e1408de_b933a3ea
PS1, Line 58: descibes
s/descibes/describes
File res/res_geolocation/wiki/Geolocation.md:
https://gerrit.asterisk.org/c/asterisk/+/18360/comment/7fe59cd0_9b45d2a6
PS1, Line 2: inplmented
s/inplmented/implemented
File res/res_geolocation/wiki/LocationConcepts.md:
https://gerrit.asterisk.org/c/asterisk/+/18360/comment/edca160f_e860eb0d
PS1, Line 14: locatons
s/locatons/locations
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18360
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: development/16/geolocation
Gerrit-Change-Id: I85b239776209bff3fc3388cf9b0a322a1764db29
Gerrit-Change-Number: 18360
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 13 Apr 2022 22:31:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220413/2af676f9/attachment.html>
More information about the asterisk-code-review
mailing list