<p> Attention is currently required from: Joshua Colp, George Joseph. </p>
<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/18360">View Change</a></p><p>8 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_geolocation/wiki/AsteriskImplementation.md:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18360/comment/a95e89d3_3ba33e6b">Patch Set #1, Line 80:</a> <code style="font-family:monospace,monospace">Any parameter than can use channel variables can also arbitrary variables defined in this paramete</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/than/that?</p><p style="white-space: pre-wrap; word-wrap: break-word;">The end reads oddly too, "..can also arbitrary variables defined.."? I'm not sure what that means.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18360/comment/5071ccc6_1852eafb">Patch Set #1, Line 80:</a> <code style="font-family:monospace,monospace">pof</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">pof?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18360/comment/0f837a6f_9d7d64bd">Patch Set #1, Line 101:</a> <code style="font-family:monospace,monospace">descibes</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/descibes/describes</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18360/comment/db0eaa9f_3ae5d274">Patch Set #1, Line 133:</a> <code style="font-family:monospace,monospace">this..</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">extra period here?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18360/comment/7394f687_aea61789">Patch Set #1, Line 144:</a> <code style="font-family:monospace,monospace">would exactly</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">would be exactly</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_geolocation/wiki/CivicAddress.md:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18360/comment/2e1408de_b933a3ea">Patch Set #1, Line 58:</a> <code style="font-family:monospace,monospace">descibes</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/descibes/describes</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_geolocation/wiki/Geolocation.md:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18360/comment/7fe59cd0_9b45d2a6">Patch Set #1, Line 2:</a> <code style="font-family:monospace,monospace">inplmented</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/inplmented/implemented</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_geolocation/wiki/LocationConcepts.md:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18360/comment/edca160f_e860eb0d">Patch Set #1, Line 14:</a> <code style="font-family:monospace,monospace">locatons</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/locatons/locations</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18360">change 18360</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18360"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: development/16/geolocation </div>
<div style="display:none"> Gerrit-Change-Id: I85b239776209bff3fc3388cf9b0a322a1764db29 </div>
<div style="display:none"> Gerrit-Change-Number: 18360 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 13 Apr 2022 22:31:05 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>