[Asterisk-code-review] res_pjsip_session: Flip stream direction of outgoing stream. (asterisk[16])

[Joshua Colp]

Attention is currently required from: Maximilian Fridrich.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18371 )

Change subject: res_pjsip_session: Flip stream direction of outgoing stream.
......................................................................


Patch Set 1:

(1 comment)

File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/18371/comment/0e69b223_67895987 
PS1, Line 3425: 			if (ast_stream_get_state(req_stream) == AST_STREAM_STATE_SENDONLY) {
> Before I keep adding tiny commits - would this be sufficient or do you want me to elaborate a bit mo […]
Gerrit doesn't work using tiny commits and separate reviews - you amend and update this review.

As for the comment it's not sufficient, because it's describing a specific scenario - while the code itself doesn't care about the scenario or really know about it.

The code is creating an outgoing session with a requested stream topology from the core.

>From elsewhere in the file:

                                /* Stream state reflects our state of a stream, so in the case of
                                 * sendonly and recvonly we store the opposite since that is what ours
                                 * is.
                                 */

In relation to the remote stream.

So right here, we want our ultimate state to be sendonly - that is only sending to them from what I understand. Is this correct, or do we actually want to be recvonly? That is: should the stream state have originally been recvonly here? What is the actually desired SDP negotiation that should happen?

There is code already swapping in bridge_simple and bridge_native_rtp the stream state when re-negotiating.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18371
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I294dc834ac9a5f048b101b691669959e9df630e1
Gerrit-Change-Number: 18371
Gerrit-PatchSet: 1
Gerrit-Owner: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Comment-Date: Wed, 13 Apr 2022 14:06:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220413/83570f8f/attachment.html>