<p> Attention is currently required from: Maximilian Fridrich. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/18371">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_pjsip_session.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18371/comment/0e69b223_67895987">Patch Set #1, Line 3425:</a> <code style="font-family:monospace,monospace">                   if (ast_stream_get_state(req_stream) == AST_STREAM_STATE_SENDONLY) {</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Before I keep adding tiny commits - would this be sufficient or do you want me to elaborate a bit mo […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Gerrit doesn't work using tiny commits and separate reviews - you amend and update this review.</p><p style="white-space: pre-wrap; word-wrap: break-word;">As for the comment it's not sufficient, because it's describing a specific scenario - while the code itself doesn't care about the scenario or really know about it.</p><p style="white-space: pre-wrap; word-wrap: break-word;">The code is creating an outgoing session with a requested stream topology from the core.</p><p style="white-space: pre-wrap; word-wrap: break-word;">From elsewhere in the file:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                                /* Stream state reflects our state of a stream, so in the case of<br>                                 * sendonly and recvonly we store the opposite since that is what ours<br>                                 * is.<br>                                 */</pre><p style="white-space: pre-wrap; word-wrap: break-word;">In relation to the remote stream.</p><p style="white-space: pre-wrap; word-wrap: break-word;">So right here, we want our ultimate state to be sendonly - that is only sending to them from what I understand. Is this correct, or do we actually want to be recvonly? That is: should the stream state have originally been recvonly here? What is the actually desired SDP negotiation that should happen?</p><p style="white-space: pre-wrap; word-wrap: break-word;">There is code already swapping in bridge_simple and bridge_native_rtp the stream state when re-negotiating.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18371">change 18371</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18371"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I294dc834ac9a5f048b101b691669959e9df630e1 </div>
<div style="display:none"> Gerrit-Change-Number: 18371 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Maximilian Fridrich <m.fridrich@commend.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Maximilian Fridrich <m.fridrich@commend.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 13 Apr 2022 14:06:16 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Comment-In-Reply-To: Maximilian Fridrich <m.fridrich@commend.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>