[Asterisk-code-review] chan_pjsip.c: allow_180_ringing_with_sdp (asterisk[16])

[Mark Petersen]

Attention is currently required from: Joshua Colp, N A, Alexei Gradinari, Mark Petersen.
Mark Petersen has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17785 )

Change subject: chan_pjsip.c: allow_180_ringing_with_sdp
......................................................................


Patch Set 13:

(2 comments)

Patchset:

PS11: 
> Alembic provides a general guide: https://alembic.sqlalchemy.org/en/latest/tutorial. […]
can you take a look at 0bee61aa9425_allow_180_ringing_with_sdp.py as I have no idea what I'm doing wrong


File channels/chan_pjsip.c:

https://gerrit.asterisk.org/c/asterisk/+/17785/comment/9ebea320_5dfee7d7 
PS5, Line 1625: 				response_code = 183;
> had to change 180_ringing_with_sdp to allow_180_ringing_with_sdp as starting with digits brakes the  […]
I have created a series of test but have run into a problem with how asterisk hande  chan_pjsip_incoming_response where we set AST_CONTROL_PROGRESS if SDP is present
so that break receiving a 180 with SDP and 183 with and AST_CONTROL_PROGRESS_SDP
but I have no idea if that is a good idea or not :-/



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17785
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I8a53f8c35595b6d16d8e86e241b5f110d92f3d18
Gerrit-Change-Number: 17785
Gerrit-PatchSet: 13
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-CC: Mark Petersen <asterisk.org at zombie.dk>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Attention: Mark Petersen <asterisk.org at zombie.dk>
Gerrit-Comment-Date: Thu, 07 Apr 2022 14:36:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Mark Petersen <bugs.digium.com at zombie.dk>
Comment-In-Reply-To: Mark Petersen <asterisk.org at zombie.dk>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220407/dfaf98f3/attachment.html>