<p> Attention is currently required from: Joshua Colp, N A, Alexei Gradinari, Mark Petersen. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/17785">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17785?tab=comments">Patch Set #11:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Alembic provides a general guide: https://alembic.sqlalchemy.org/en/latest/tutorial. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">can you take a look at 0bee61aa9425_allow_180_ringing_with_sdp.py as I have no idea what I'm doing wrong</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File channels/chan_pjsip.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17785/comment/9ebea320_5dfee7d7">Patch Set #5, Line 1625:</a> <code style="font-family:monospace,monospace"> response_code = 183;</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">had to change 180_ringing_with_sdp to allow_180_ringing_with_sdp as starting with digits brakes the […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I have created a series of test but have run into a problem with how asterisk hande chan_pjsip_incoming_response where we set AST_CONTROL_PROGRESS if SDP is present<br>so that break receiving a 180 with SDP and 183 with and AST_CONTROL_PROGRESS_SDP<br>but I have no idea if that is a good idea or not :-/</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/17785">change 17785</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/17785"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I8a53f8c35595b6d16d8e86e241b5f110d92f3d18 </div>
<div style="display:none"> Gerrit-Change-Number: 17785 </div>
<div style="display:none"> Gerrit-PatchSet: 13 </div>
<div style="display:none"> Gerrit-Owner: Mark Petersen <bugs.digium.com@zombie.dk> </div>
<div style="display:none"> Gerrit-Reviewer: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-CC: Mark Petersen <asterisk.org@zombie.dk> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Attention: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Attention: Mark Petersen <asterisk.org@zombie.dk> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 07 Apr 2022 14:36:13 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Comment-In-Reply-To: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Comment-In-Reply-To: Mark Petersen <bugs.digium.com@zombie.dk> </div>
<div style="display:none"> Comment-In-Reply-To: Mark Petersen <asterisk.org@zombie.dk> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>