[Asterisk-code-review] STIR/SHAKEN: Update config options and skip some tests. (testsuite[18])

[Friendly Automation]

Friendly Automation has submitted this change. ( https://gerrit.asterisk.org/c/testsuite/+/16522 )

Change subject: STIR/SHAKEN: Update config options and skip some tests.
......................................................................

STIR/SHAKEN: Update config options and skip some tests.

The stir_shaken config option is being updated so that you can choose if
you want to do attestation, verification, or both. The tests need to be
updated for this as well.

For now, skip all the tests except stir_shaken_success. We are going to
need to switch to sipp for these tests since response codes are being
sent back now and we can no longer check the verification result to pass
the tests. Some additional work is going to needed for this since we
will have to have a way to pass in a dynamic Identity and Date header to
sipp.

Change-Id: I9b6186dc74dc1c34637a8ea9f4be4c8bf8f8f449
---
M tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast1/pjsip.conf
M tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast2/pjsip.conf
M tests/channels/pjsip/stir_shaken/stir_shaken_failed/test-config.yaml
M tests/channels/pjsip/stir_shaken/stir_shaken_mismatch/test-config.yaml
M tests/channels/pjsip/stir_shaken/stir_shaken_not_present/configs/ast2/pjsip.conf
M tests/channels/pjsip/stir_shaken/stir_shaken_not_present/test-config.yaml
M tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast1/pjsip.conf
M tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast2/pjsip.conf
8 files changed, 8 insertions(+), 5 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  Kevin Harwell: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit



diff --git a/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast1/pjsip.conf b/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast1/pjsip.conf
index 675fafd..393a561 100644
--- a/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast1/pjsip.conf
@@ -15,7 +15,7 @@
 transport=transport-udp
 allow=!all,ulaw
 callerid=1234567
-stir_shaken=yes
+stir_shaken=attest
 
 [aor-bob]
 type=aor
diff --git a/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast2/pjsip.conf b/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast2/pjsip.conf
index 8b4dbb2..fcbfdcb 100644
--- a/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast2/pjsip.conf
+++ b/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast2/pjsip.conf
@@ -13,4 +13,4 @@
 context=default
 allow=!all,ulaw
 callerid=1234567
-stir_shaken=yes
+stir_shaken=verify
diff --git a/tests/channels/pjsip/stir_shaken/stir_shaken_failed/test-config.yaml b/tests/channels/pjsip/stir_shaken/stir_shaken_failed/test-config.yaml
index 5707c52..3016696 100644
--- a/tests/channels/pjsip/stir_shaken/stir_shaken_failed/test-config.yaml
+++ b/tests/channels/pjsip/stir_shaken/stir_shaken_failed/test-config.yaml
@@ -1,4 +1,5 @@
 testinfo:
+    skip: 'Skip until swapped to sipp, which will probably require additional work in the testsuite'
     summary:     'Tests STIR_SHAKEN_SIGNATURE_FAILED'
     description: |
         'Run two instances of Asterisk and set up an outgoing call
diff --git a/tests/channels/pjsip/stir_shaken/stir_shaken_mismatch/test-config.yaml b/tests/channels/pjsip/stir_shaken/stir_shaken_mismatch/test-config.yaml
index ff6a57d..eaf9147 100644
--- a/tests/channels/pjsip/stir_shaken/stir_shaken_mismatch/test-config.yaml
+++ b/tests/channels/pjsip/stir_shaken/stir_shaken_mismatch/test-config.yaml
@@ -1,4 +1,5 @@
 testinfo:
+    skip: 'Skip until swapped to sipp, which will probably require additional work in the testsuite'
     summary:     'Tests STIR_SHAKEN_VERIFY_MISMATCH'
     description: |
         'Run one instance of Asterisk and set up an incoming call
diff --git a/tests/channels/pjsip/stir_shaken/stir_shaken_not_present/configs/ast2/pjsip.conf b/tests/channels/pjsip/stir_shaken/stir_shaken_not_present/configs/ast2/pjsip.conf
index 8b4dbb2..fcbfdcb 100644
--- a/tests/channels/pjsip/stir_shaken/stir_shaken_not_present/configs/ast2/pjsip.conf
+++ b/tests/channels/pjsip/stir_shaken/stir_shaken_not_present/configs/ast2/pjsip.conf
@@ -13,4 +13,4 @@
 context=default
 allow=!all,ulaw
 callerid=1234567
-stir_shaken=yes
+stir_shaken=verify
diff --git a/tests/channels/pjsip/stir_shaken/stir_shaken_not_present/test-config.yaml b/tests/channels/pjsip/stir_shaken/stir_shaken_not_present/test-config.yaml
index e4b43a3..27efb5a 100644
--- a/tests/channels/pjsip/stir_shaken/stir_shaken_not_present/test-config.yaml
+++ b/tests/channels/pjsip/stir_shaken/stir_shaken_not_present/test-config.yaml
@@ -1,4 +1,5 @@
 testinfo:
+    skip: 'Skip until swapped to sipp, which will probably require additional work in the testsuite'
     summary:     'Tests STIR_SHAKEN_VERIFY_NOT_PRESENT'
     description: |
         'Run two instances of Asterisk and set up an outgoing call
diff --git a/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast1/pjsip.conf b/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast1/pjsip.conf
index 675fafd..393a561 100644
--- a/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast1/pjsip.conf
@@ -15,7 +15,7 @@
 transport=transport-udp
 allow=!all,ulaw
 callerid=1234567
-stir_shaken=yes
+stir_shaken=attest
 
 [aor-bob]
 type=aor
diff --git a/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast2/pjsip.conf b/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast2/pjsip.conf
index 8b4dbb2..fcbfdcb 100644
--- a/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast2/pjsip.conf
+++ b/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast2/pjsip.conf
@@ -13,4 +13,4 @@
 context=default
 allow=!all,ulaw
 callerid=1234567
-stir_shaken=yes
+stir_shaken=verify

-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/16522
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 18
Gerrit-Change-Id: I9b6186dc74dc1c34637a8ea9f4be4c8bf8f8f449
Gerrit-Change-Number: 16522
Gerrit-PatchSet: 3
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211027/2ad276c7/attachment-0001.html>