<p>Friendly Automation <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/testsuite/+/16522">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  Kevin Harwell: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">STIR/SHAKEN: Update config options and skip some tests.<br><br>The stir_shaken config option is being updated so that you can choose if<br>you want to do attestation, verification, or both. The tests need to be<br>updated for this as well.<br><br>For now, skip all the tests except stir_shaken_success. We are going to<br>need to switch to sipp for these tests since response codes are being<br>sent back now and we can no longer check the verification result to pass<br>the tests. Some additional work is going to needed for this since we<br>will have to have a way to pass in a dynamic Identity and Date header to<br>sipp.<br><br>Change-Id: I9b6186dc74dc1c34637a8ea9f4be4c8bf8f8f449<br>---<br>M tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast1/pjsip.conf<br>M tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast2/pjsip.conf<br>M tests/channels/pjsip/stir_shaken/stir_shaken_failed/test-config.yaml<br>M tests/channels/pjsip/stir_shaken/stir_shaken_mismatch/test-config.yaml<br>M tests/channels/pjsip/stir_shaken/stir_shaken_not_present/configs/ast2/pjsip.conf<br>M tests/channels/pjsip/stir_shaken/stir_shaken_not_present/test-config.yaml<br>M tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast1/pjsip.conf<br>M tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast2/pjsip.conf<br>8 files changed, 8 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast1/pjsip.conf b/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast1/pjsip.conf</span><br><span>index 675fafd..393a561 100644</span><br><span>--- a/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast1/pjsip.conf</span><br><span>+++ b/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast1/pjsip.conf</span><br><span>@@ -15,7 +15,7 @@</span><br><span> transport=transport-udp</span><br><span> allow=!all,ulaw</span><br><span> callerid=1234567</span><br><span style="color: hsl(0, 100%, 40%);">-stir_shaken=yes</span><br><span style="color: hsl(120, 100%, 40%);">+stir_shaken=attest</span><br><span> </span><br><span> [aor-bob]</span><br><span> type=aor</span><br><span>diff --git a/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast2/pjsip.conf b/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast2/pjsip.conf</span><br><span>index 8b4dbb2..fcbfdcb 100644</span><br><span>--- a/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast2/pjsip.conf</span><br><span>+++ b/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast2/pjsip.conf</span><br><span>@@ -13,4 +13,4 @@</span><br><span> context=default</span><br><span> allow=!all,ulaw</span><br><span> callerid=1234567</span><br><span style="color: hsl(0, 100%, 40%);">-stir_shaken=yes</span><br><span style="color: hsl(120, 100%, 40%);">+stir_shaken=verify</span><br><span>diff --git a/tests/channels/pjsip/stir_shaken/stir_shaken_failed/test-config.yaml b/tests/channels/pjsip/stir_shaken/stir_shaken_failed/test-config.yaml</span><br><span>index 5707c52..3016696 100644</span><br><span>--- a/tests/channels/pjsip/stir_shaken/stir_shaken_failed/test-config.yaml</span><br><span>+++ b/tests/channels/pjsip/stir_shaken/stir_shaken_failed/test-config.yaml</span><br><span>@@ -1,4 +1,5 @@</span><br><span> testinfo:</span><br><span style="color: hsl(120, 100%, 40%);">+    skip: 'Skip until swapped to sipp, which will probably require additional work in the testsuite'</span><br><span>     summary:     'Tests STIR_SHAKEN_SIGNATURE_FAILED'</span><br><span>     description: |</span><br><span>         'Run two instances of Asterisk and set up an outgoing call</span><br><span>diff --git a/tests/channels/pjsip/stir_shaken/stir_shaken_mismatch/test-config.yaml b/tests/channels/pjsip/stir_shaken/stir_shaken_mismatch/test-config.yaml</span><br><span>index ff6a57d..eaf9147 100644</span><br><span>--- a/tests/channels/pjsip/stir_shaken/stir_shaken_mismatch/test-config.yaml</span><br><span>+++ b/tests/channels/pjsip/stir_shaken/stir_shaken_mismatch/test-config.yaml</span><br><span>@@ -1,4 +1,5 @@</span><br><span> testinfo:</span><br><span style="color: hsl(120, 100%, 40%);">+    skip: 'Skip until swapped to sipp, which will probably require additional work in the testsuite'</span><br><span>     summary:     'Tests STIR_SHAKEN_VERIFY_MISMATCH'</span><br><span>     description: |</span><br><span>         'Run one instance of Asterisk and set up an incoming call</span><br><span>diff --git a/tests/channels/pjsip/stir_shaken/stir_shaken_not_present/configs/ast2/pjsip.conf b/tests/channels/pjsip/stir_shaken/stir_shaken_not_present/configs/ast2/pjsip.conf</span><br><span>index 8b4dbb2..fcbfdcb 100644</span><br><span>--- a/tests/channels/pjsip/stir_shaken/stir_shaken_not_present/configs/ast2/pjsip.conf</span><br><span>+++ b/tests/channels/pjsip/stir_shaken/stir_shaken_not_present/configs/ast2/pjsip.conf</span><br><span>@@ -13,4 +13,4 @@</span><br><span> context=default</span><br><span> allow=!all,ulaw</span><br><span> callerid=1234567</span><br><span style="color: hsl(0, 100%, 40%);">-stir_shaken=yes</span><br><span style="color: hsl(120, 100%, 40%);">+stir_shaken=verify</span><br><span>diff --git a/tests/channels/pjsip/stir_shaken/stir_shaken_not_present/test-config.yaml b/tests/channels/pjsip/stir_shaken/stir_shaken_not_present/test-config.yaml</span><br><span>index e4b43a3..27efb5a 100644</span><br><span>--- a/tests/channels/pjsip/stir_shaken/stir_shaken_not_present/test-config.yaml</span><br><span>+++ b/tests/channels/pjsip/stir_shaken/stir_shaken_not_present/test-config.yaml</span><br><span>@@ -1,4 +1,5 @@</span><br><span> testinfo:</span><br><span style="color: hsl(120, 100%, 40%);">+    skip: 'Skip until swapped to sipp, which will probably require additional work in the testsuite'</span><br><span>     summary:     'Tests STIR_SHAKEN_VERIFY_NOT_PRESENT'</span><br><span>     description: |</span><br><span>         'Run two instances of Asterisk and set up an outgoing call</span><br><span>diff --git a/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast1/pjsip.conf b/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast1/pjsip.conf</span><br><span>index 675fafd..393a561 100644</span><br><span>--- a/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast1/pjsip.conf</span><br><span>+++ b/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast1/pjsip.conf</span><br><span>@@ -15,7 +15,7 @@</span><br><span> transport=transport-udp</span><br><span> allow=!all,ulaw</span><br><span> callerid=1234567</span><br><span style="color: hsl(0, 100%, 40%);">-stir_shaken=yes</span><br><span style="color: hsl(120, 100%, 40%);">+stir_shaken=attest</span><br><span> </span><br><span> [aor-bob]</span><br><span> type=aor</span><br><span>diff --git a/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast2/pjsip.conf b/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast2/pjsip.conf</span><br><span>index 8b4dbb2..fcbfdcb 100644</span><br><span>--- a/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast2/pjsip.conf</span><br><span>+++ b/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast2/pjsip.conf</span><br><span>@@ -13,4 +13,4 @@</span><br><span> context=default</span><br><span> allow=!all,ulaw</span><br><span> callerid=1234567</span><br><span style="color: hsl(0, 100%, 40%);">-stir_shaken=yes</span><br><span style="color: hsl(120, 100%, 40%);">+stir_shaken=verify</span><br><span></span><br></pre><div style="white-space:pre-wrap"></div><p>To view, visit <a href="https://gerrit.asterisk.org/c/testsuite/+/16522">change 16522</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/testsuite/+/16522"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: 18 </div>
<div style="display:none"> Gerrit-Change-Id: I9b6186dc74dc1c34637a8ea9f4be4c8bf8f8f449 </div>
<div style="display:none"> Gerrit-Change-Number: 16522 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>