[Asterisk-code-review] test_voicemail_api.c: changing empty_msg_ids from 0 element array to ... (asterisk[master])

[Sean Bright]

Attention is currently required from: Michael Bradeen.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16571 )

Change subject: test_voicemail_api.c: changing empty_msg_ids from 0 element array to empty char* chan_skinny.c: changed calledParty size to AST_MAX_EXTENSION menuselect Makefile: added -Wno-deprecated-declarations
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/16571/comment/7037e58c_bc90967c 
PS1, Line 7: test_voicemail_api.c: changing empty_msg_ids from 0 element array to empty char*
           : chan_skinny.c: changed calledParty size to AST_MAX_EXTENSION
           : menuselect Makefile: added -Wno-deprecated-declarations
You should add a one-liner description, followed by a blank line, followed by the more detailed explanation. See this page for more info:

https://wiki.asterisk.org/wiki/display/AST/Commit+Messages


https://gerrit.asterisk.org/c/asterisk/+/16571/comment/2c32dcdf_52004c72 
PS1, Line 13: SWP-11547
No one outside of Sangoma knows what this is. Is there an associated public issue that starts with ASTERISK-?


File menuselect/Makefile:

https://gerrit.asterisk.org/c/asterisk/+/16571/comment/9ce01e34_8e408ecd 
PS1, Line 25: CFLAGS+=-g -D_GNU_SOURCE -Wall -Wno-deprecated-declarations
What error is this papering over? Would it be cleaner to stop using the deprecated functions?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16571
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If4fe42222c8444dc16828a42731ee53b4ce5cbbe
Gerrit-Change-Number: 16571
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Friendly Automation
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Thu, 07 Oct 2021 18:17:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211007/1f9aed09/attachment.html>