<p> Attention is currently required from: Michael Bradeen. </p>
<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/16571">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16571/comment/7037e58c_bc90967c">Patch Set #1, Line 7:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">test_voicemail_api.c: changing empty_msg_ids from 0 element array to empty char*<br>chan_skinny.c: changed calledParty size to AST_MAX_EXTENSION<br>menuselect Makefile: added -Wno-deprecated-declarations<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">You should add a one-liner description, followed by a blank line, followed by the more detailed explanation. See this page for more info:</p><p style="white-space: pre-wrap; word-wrap: break-word;">https://wiki.asterisk.org/wiki/display/AST/Commit+Messages</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16571/comment/2c32dcdf_52004c72">Patch Set #1, Line 13:</a> <code style="font-family:monospace,monospace">SWP-11547</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">No one outside of Sangoma knows what this is. Is there an associated public issue that starts with ASTERISK-?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File menuselect/Makefile:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16571/comment/9ce01e34_8e408ecd">Patch Set #1, Line 25:</a> <code style="font-family:monospace,monospace">CFLAGS+=-g -D_GNU_SOURCE -Wall -Wno-deprecated-declarations</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">What error is this papering over? Would it be cleaner to stop using the deprecated functions?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16571">change 16571</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16571"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If4fe42222c8444dc16828a42731ee53b4ce5cbbe </div>
<div style="display:none"> Gerrit-Change-Number: 16571 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-CC: Friendly Automation </div>
<div style="display:none"> Gerrit-Attention: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 07 Oct 2021 18:17:01 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>