[Asterisk-code-review] app_voicemail: Refactor email generation functions (asterisk[master])

[N A]

Attention is currently required from: Sean Bright, Joshua Colp, Stanislav Abramenkov, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16665 )

Change subject: app_voicemail: Refactor email generation functions
......................................................................


Patch Set 5:

(2 comments)

File include/asterisk/utils.h:

https://gerrit.asterisk.org/c/asterisk/+/16665/comment/6d3cc347_d9a419ec 
PS3, Line 198: #define SENDMAIL "/usr/sbin/sendmail -t"
             : #define ENDL "\n"
> > SENDMAIL I feel should stay in utils.h since utils does not use SENDMAIL at all internally. […]
Okay, fair point. I'll duplicate these in the modules that need them.


File main/utils.c:

https://gerrit.asterisk.org/c/asterisk/+/16665/comment/902e8a9c_c7a91d4d 
PS5, Line 652: int ast_file_base_encode(char *filename, FILE *so)
> Before this goes in, we need to be 1000% sure that this is the API we want. […]
This is the same API as it was, I didn't change it. base_encode accepts the file name (path) of the attachment and so is a pointer to the file descriptor for where to dump the base encoded content.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16665
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I1de0ed3483623e9599711129edc817c45ad237ee
Gerrit-Change-Number: 16665
Gerrit-PatchSet: 5
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 01 Nov 2021 20:12:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211101/5fc56a21/attachment.html>