[Asterisk-code-review] app_voicemail: Refactor email generation functions (asterisk[master])

[Sean Bright]

Attention is currently required from: N A, Joshua Colp, Stanislav Abramenkov, George Joseph.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16665 )

Change subject: app_voicemail: Refactor email generation functions
......................................................................


Patch Set 5: Code-Review-1

(2 comments)

File apps/app_voicemail.c:

https://gerrit.asterisk.org/c/asterisk/+/16665/comment/01a9404c_3cb83773 
PS5, Line 542: #ifdef IMAP_STORAGE
             : #define ENDL "\r\n"
             : #else
             : #define ENDL "\n"
             : #endif
Before your patch, the base64 encoding would use the ENDL defined here. Now it will only use \n. You may need to have your new encoding function take an EOL character sequence.


File main/utils.c:

https://gerrit.asterisk.org/c/asterisk/+/16665/comment/3d90c833_9a3719f6 
PS5, Line 652: int ast_file_base_encode(char *filename, FILE *so)
Before this goes in, we need to be 1000% sure that this is the API we want. I think it should either take two paths or two FILE *s but not a combination of the two.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16665
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I1de0ed3483623e9599711129edc817c45ad237ee
Gerrit-Change-Number: 16665
Gerrit-PatchSet: 5
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 01 Nov 2021 20:10:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211101/640334bc/attachment-0001.html>