[Asterisk-code-review] res_pjsip_outbound_authenticaor_digest: Be tolerant of RFC8760 UASs (asterisk[16])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15764 )

Change subject: res_pjsip_outbound_authenticaor_digest: Be tolerant of RFC8760 UASs
......................................................................


Patch Set 3: Code-Review-1

(9 comments)

Ooff read for typos 😜

https://gerrit.asterisk.org/c/asterisk/+/15764/3//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/15764/3//COMMIT_MSG@21 
PS3, Line 21: aggregate all of the Authenticate headers and then them all back
s/then them/send them/


https://gerrit.asterisk.org/c/asterisk/+/15764/3/res/res_pjsip.c 
File res/res_pjsip.c:

https://gerrit.asterisk.org/c/asterisk/+/15764/3/res/res_pjsip.c@1305 
PS3, Line 1305: 							If more than 1 auth object with the same realm or
              : 								more than 1 wildcard auth object associated to
Should spell out 1 (one).


https://gerrit.asterisk.org/c/asterisk/+/15764/3/res/res_pjsip_outbound_authenticator_digest.c 
File res/res_pjsip_outbound_authenticator_digest.c:

https://gerrit.asterisk.org/c/asterisk/+/15764/3/res/res_pjsip_outbound_authenticator_digest.c@99 
PS3, Line 99: others. Within a realm.
...others within a realm.


https://gerrit.asterisk.org/c/asterisk/+/15764/3/res/res_pjsip_outbound_authenticator_digest.c@196 
PS3, Line 196: insude
s/insude/inside/


https://gerrit.asterisk.org/c/asterisk/+/15764/3/res/res_pjsip_outbound_authenticator_digest.c@208 
PS3, Line 208: 		 * there can't be more than 1 header with the same realm.  No need to worry
spell out 1 (one)


https://gerrit.asterisk.org/c/asterisk/+/15764/3/res/res_pjsip_outbound_authenticator_digest.c@285 
PS3, Line 285: 			 * We'll only usae the  wildcard if we didn't find an exact match.
s/usae/use/
also extra space between "the  wildcard"


https://gerrit.asterisk.org/c/asterisk/+/15764/3/res/res_pjsip_outbound_authenticator_digest.c@330 
PS3, Line 330: 		 * Again, this is structly so digest_create_request_with_auth()
s/structly/strictly/


https://gerrit.asterisk.org/c/asterisk/+/15764/3/res/res_pjsip_outbound_authenticator_digest.c@436 
PS3, Line 436: 	 * 	ast_sip_cleanup_auth_objects_vector(&auth_objects_vector);
There is an extraneous tab within the comment between "*  ast_sip_cleanup..."


https://gerrit.asterisk.org/c/asterisk/+/15764/3/res/res_pjsip_outbound_authenticator_digest.c@493 
PS3, Line 493: 	 * from an earlier successful authorization, it'll use it,otherwise
run on sentence

...it'll use it.  Otherwise,



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15764
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I3aef5ce4fe1d27e48d61268520f284d15d650281
Gerrit-Change-Number: 15764
Gerrit-PatchSet: 3
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 06 May 2021 15:11:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210506/f9e13787/attachment-0001.html>