<p style="white-space: pre-wrap; word-wrap: break-word;">Ooff read for typos 😜</p><p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15764">View Change</a></p><p>9 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15764/3//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15764/3//COMMIT_MSG@21">Patch Set #3, Line 21:</a> <code style="font-family:monospace,monospace">aggregate all of the Authenticate headers and then them all back</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/then them/send them/</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15764/3/res/res_pjsip.c">File res/res_pjsip.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15764/3/res/res_pjsip.c@1305">Patch Set #3, Line 1305:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                                                  If more than 1 auth object with the same realm or<br>                                                             more than 1 wildcard auth object associated to<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should spell out 1 (one).</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15764/3/res/res_pjsip_outbound_authenticator_digest.c">File res/res_pjsip_outbound_authenticator_digest.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15764/3/res/res_pjsip_outbound_authenticator_digest.c@99">Patch Set #3, Line 99:</a> <code style="font-family:monospace,monospace">others. Within a realm.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">...others within a realm.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15764/3/res/res_pjsip_outbound_authenticator_digest.c@196">Patch Set #3, Line 196:</a> <code style="font-family:monospace,monospace">insude</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/insude/inside/</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15764/3/res/res_pjsip_outbound_authenticator_digest.c@208">Patch Set #3, Line 208:</a> <code style="font-family:monospace,monospace">               * there can't be more than 1 header with the same realm.  No need to worry</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">spell out 1 (one)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15764/3/res/res_pjsip_outbound_authenticator_digest.c@285">Patch Set #3, Line 285:</a> <code style="font-family:monospace,monospace">                    * We'll only usae the  wildcard if we didn't find an exact match.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/usae/use/<br>also extra space between "the  wildcard"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15764/3/res/res_pjsip_outbound_authenticator_digest.c@330">Patch Set #3, Line 330:</a> <code style="font-family:monospace,monospace">           * Again, this is structly so digest_create_request_with_auth()</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/structly/strictly/</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15764/3/res/res_pjsip_outbound_authenticator_digest.c@436">Patch Set #3, Line 436:</a> <code style="font-family:monospace,monospace">         *      ast_sip_cleanup_auth_objects_vector(&auth_objects_vector);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">There is an extraneous tab within the comment between "*  ast_sip_cleanup..."</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15764/3/res/res_pjsip_outbound_authenticator_digest.c@493">Patch Set #3, Line 493:</a> <code style="font-family:monospace,monospace">       * from an earlier successful authorization, it'll use it,otherwise</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">run on sentence</p><p style="white-space: pre-wrap; word-wrap: break-word;">...it'll use it.  Otherwise,</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15764">change 15764</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15764"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I3aef5ce4fe1d27e48d61268520f284d15d650281 </div>
<div style="display:none"> Gerrit-Change-Number: 15764 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 06 May 2021 15:11:43 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>