[Asterisk-code-review] core_unreal: Fix deadlock with T.38 control frames. (asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15651 )

Change subject: core_unreal: Fix deadlock with T.38 control frames.
......................................................................


Patch Set 3:

> Patch Set 3: Code-Review+1
> 
> Looks ok to me.
> 
> I note in channel.c:ast_write_stream() that it starts off doing deadlock avoidance locking chan.  I don't know if that is still needed because there are several cases throughout the function where chan is temporarily unlocked and relocked.  ast_write_stream() calls indicate_data_internal() which does this for several channel drivers.

I think that would be a separate patch for a future improvement.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15651
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Id65016201b5f9c9519a216e250f9101c629e19e9
Gerrit-Change-Number: 15651
Gerrit-PatchSet: 3
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 19 Mar 2021 15:01:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210319/ace3b626/attachment.html>