<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 3: Code-Review+1</p><p style="white-space: pre-wrap; word-wrap: break-word;">Looks ok to me.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I note in channel.c:ast_write_stream() that it starts off doing deadlock avoidance locking chan.  I don't know if that is still needed because there are several cases throughout the function where chan is temporarily unlocked and relocked.  ast_write_stream() calls indicate_data_internal() which does this for several channel drivers.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">I think that would be a separate patch for a future improvement.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15651">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15651">change 15651</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15651"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: Id65016201b5f9c9519a216e250f9101c629e19e9 </div>
<div style="display:none"> Gerrit-Change-Number: 15651 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 19 Mar 2021 15:01:38 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>