[Asterisk-code-review] core_unreal: Fix T.38 faxing when using local channels. (asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15332 )

Change subject: core_unreal: Fix T.38 faxing when using local channels.
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/c/asterisk/+/15332/1/include/asterisk/core_unreal.h 
File include/asterisk/core_unreal.h:

https://gerrit.asterisk.org/c/asterisk/+/15332/1/include/asterisk/core_unreal.h@101 
PS1, Line 101: 	struct ast_stream_topology *oldtopology[2]; /*!< Stored topologies for both local pairs for when we need to restore later (faxing) */
Document which position in the array is each


https://gerrit.asterisk.org/c/asterisk/+/15332/1/main/core_unreal.c 
File main/core_unreal.c:

https://gerrit.asterisk.org/c/asterisk/+/15332/1/main/core_unreal.c@713 
PS1, Line 713: 			ast_unreal_lock_all(p, &chan, &owner);
Is it possible for chan or owner to be NULL on return from this?


https://gerrit.asterisk.org/c/asterisk/+/15332/1/main/core_unreal.c@719 
PS1, Line 719: 			 * Bump the ref for new_topology, since it will be used by both local pairs. This way, when
This comment isn't exactly correct. One channel is taking the reference from the ao2_ref, and one channel is inheriting the reference from ast_stream_topology_alloc.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15332
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Id103cc5c9295295d8e68d5628e76220f8f17e9fb
Gerrit-Change-Number: 15332
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 26 Jan 2021 11:47:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210126/b35e2b81/attachment.html>