<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15332">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15332/1/include/asterisk/core_unreal.h">File include/asterisk/core_unreal.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15332/1/include/asterisk/core_unreal.h@101">Patch Set #1, Line 101:</a> <code style="font-family:monospace,monospace">    struct ast_stream_topology *oldtopology[2]; /*!< Stored topologies for both local pairs for when we need to restore later (faxing) */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Document which position in the array is each</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15332/1/main/core_unreal.c">File main/core_unreal.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15332/1/main/core_unreal.c@713">Patch Set #1, Line 713:</a> <code style="font-family:monospace,monospace">                    ast_unreal_lock_all(p, &chan, &owner);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Is it possible for chan or owner to be NULL on return from this?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15332/1/main/core_unreal.c@719">Patch Set #1, Line 719:</a> <code style="font-family:monospace,monospace">                         * Bump the ref for new_topology, since it will be used by both local pairs. This way, when</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This comment isn't exactly correct. One channel is taking the reference from the ao2_ref, and one channel is inheriting the reference from ast_stream_topology_alloc.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15332">change 15332</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15332"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: Id103cc5c9295295d8e68d5628e76220f8f17e9fb </div>
<div style="display:none"> Gerrit-Change-Number: 15332 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 26 Jan 2021 11:47:37 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>